Add value formatting to charts ($, %, units)#1247
Conversation
🚀 Preview Deployment
Preview will be automatically removed when this PR is closed. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 15 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 3 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
…rmatting-1115 # Conflicts: # apps/backend/src/utils/story-html.tsx # apps/frontend/src/components/settings/usage-chart-card.tsx # apps/frontend/src/components/side-panel/story-chart-embed.tsx # apps/frontend/src/components/tool-calls/display-chart-edit-dialog.tsx # apps/frontend/src/components/tool-calls/display-chart.tsx # apps/frontend/src/components/ui/chart.tsx # apps/frontend/src/routes/_sidebar-layout.settings.usage.tsx # apps/shared/src/chart-builder.tsx # apps/shared/src/story-segments.ts # apps/shared/src/tools/display-chart.ts # apps/shared/tests/chart-builder.test.tsx
|
LGTM, last commit was just frontend changes to improve the UX as requested and to make sure the new dual-axis charts also support value formatting |
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
3 participants
Summary
%, or any unit (e.g. V, kg, GB) instead of bare numbers.$.$1,000,000) so they no longer clip.Closes #1115